chore(blockifier): add text file with current compiler version for CI use #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
dorimedini-starkware
requested review from
noaov1,
AvivYossef-starkware,
meship-starkware and
aner-starkware
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
e3b2330
to
e62e313
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
2618e0f
to
e073a68
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
e62e313
to
4fe6734
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
e073a68
to
0cc6a4f
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
4fe6734
to
9facef4
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
0cc6a4f
to
f400d64
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
9facef4
to
0d099c5
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
f400d64
to
58aca6d
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
0d099c5
to
a12e845
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
58aca6d
to
7b79e6f
Compare
|
imo, this is not a good idea. Apart from having to maintain 2 locations now instead of only the Code quote: v2.7.0-rc.3 |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)
crates/blockifier/tests/legacy_cairo1_compiler_tag.txt line 1 at r2 (raw file):
v2.1.0
What's the idea here?
Code quote:
v2.1.0
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
a12e845
to
d2dd1b8
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
7b79e6f
to
738d7f2
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
d2dd1b8
to
10d4789
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
8ad0c34
to
1f6f2aa
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1)
crates/blockifier/tests/legacy_cairo1_compiler_tag.txt line 1 at r2 (raw file):
Previously, aner-starkware wrote…
Why not hardcode in the CI instead of in a different file? The test can check that the hardcoded constant in the CI is equal to the expected.
actually I think it's not even needed anymore, see top of the stack
aner-starkware
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
031e4da
to
6e5f836
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
1f6f2aa
to
e11a98a
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
6e5f836
to
9942ae2
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
2 times, most recently
from
4b6aa3d
to
ae71e03
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
9942ae2
to
0895bc5
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
ae71e03
to
3fd07d1
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
0895bc5
to
388820c
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
3fd07d1
to
07ec736
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
388820c
to
7a76151
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
07ec736
to
f623af9
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
7a76151
to
83dc987
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
f623af9
to
1b9c871
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
83dc987
to
b29a56b
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
1b9c871
to
452fc59
Compare
TzahiTaub
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Reviewed 1 of 4 files at r6, 2 of 4 files at r7, 2 of 2 files at r9, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
branch
from
b29a56b
to
9d6f7ff
Compare
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
452fc59
to
ce6fbbf
Compare
TzahiTaub
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status:
Merge activity
|
dorimedini-starkware
changed the base branch from
07-30-chore_blockifier_verify_local_cairo_repo_state_before_compiling
to
graphite-base/195
dorimedini-starkware
force-pushed
the
07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use
branch
from
ce6fbbf
to
688beb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is